Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • TextureVk.cpp
Find file
BlameHistoryPermalink
  • Shahbaz Youssefi's avatar
    Vulkan: Fix format properties queries · 96bd8fdf
    Shahbaz Youssefi authored Nov 30, 2018
    When querying format properties (in vk::GetFormatProperties), the
    mandatory feature support table was consulted to check whether a number
    of texture features are present.  If so, the entry from that table was
    returned.  The goal had been to speed up initialization by not issuing
    device queries if possible.
    
    That is, when vk::GetFormatProperties was called on a format, if it
    supported that select few texture features, the VkFormatProperties entry
    from the mandatory table would be returned.
    
    However, that function found its way to other uses (such as querying
    buffer format properties, or other image properties beyond the select
    few).  As a result, when the VkFormatProperties from the mandatory table
    was returned, actual support for these other features was often not
    tested and assumed false (unless they happened to be mandatory as well).
    
    This commit reworks the format feature query functions such that the
    specific features to be tested are provided when querying the format
    properties.  The mandatory table is consulted as before, and if the
    entry doesn't contain those features, the device is queried and the
    results cached.
    
    Bug: angleproject:2958
    Change-Id: I28d046eb63c3bd5173468aa4cb3e4c63c83e67b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1357152Reviewed-by: 's avatarTobin Ehlis <tobine@google.com>
    Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    96bd8fdf
TextureVk.cpp 47.2 KB
EditWeb IDE
×

Replace TextureVk.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.