Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • feature_support_util
  • feature_support_util.cpp
Find file
BlameHistoryPermalink
  • Ian Elliott's avatar
    Fix crash in A4A opt-in/out logic. · 9092bdc7
    Ian Elliott authored Dec 06, 2018
    The Device::match() method used to call the old ListOf<T>::match()
    method with ListOf<T>::front(), assuming that front() always returned
    a valid object reference.  It did not (e.g. the default rule had a
    wildcarded device that had no GPU).
    
    A new ListOf<T>::match() was created (for the GPU case) that compares
    to ListOf<T> objects.  If either/both is wildcarded, true is quickly
    returned.  If both are not wildcarded, they will have one or more T's,
    and these are iterated through (one in the new method, and one by
    calling the old method).
    
    During rule processing, it is safe to directly call the old method for
    a Rule's ListOf<{Device|Application}>, and so the old method is retained.
    
    Change-Id: Iea47075c38dc45eb32e1810c4997b8cfb2fe9ec3
    Reviewed-on: https://chromium-review.googlesource.com/c/1365678
    Commit-Queue: Ian Elliott <ianelliott@google.com>
    Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    Reviewed-by: 's avatarCourtney Goeltzenleuchter <courtneygo@google.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    9092bdc7
feature_support_util.cpp 36.4 KB
EditWeb IDE
×

Replace feature_support_util.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.