Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • Program.cpp
Find file
BlameHistoryPermalink
  • James Darpinian's avatar
    WebGL: validate texture format matches sampler type · e4109f27
    James Darpinian authored Dec 13, 2018
    WebGL requires that drawing produces INVALID_OPERATION if a texture's
    format doesn't match the sampler type it is bound to. This is a little
    confusing because samplers have two attributes that could be called
    "type": addressing mode (2D/3D/Cube), and component format
    (float/signed/unsigned/shadow). ANGLE already handled checking the
    addressing mode; this change adds checking for the component format.
    
    Fixes WebGL conformance test
    conformance2/uniforms/incompatible-texture-type-for-sampler.html
    
    Bug: chromium:809237
    Change-Id: I52ebfecd92625e3ee10274cb5f548d7e53de72dd
    Reviewed-on: https://chromium-review.googlesource.com/c/1377611Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org>
    Commit-Queue: James Darpinian <jdarpinian@chromium.org>
    e4109f27
Program.cpp 135 KB
EditWeb IDE
×

Replace Program.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.