Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • UtilsVk.cpp
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    Vulkan: Store reference to context command buffer. · 85ca1895
    Jamie Madill authored Jan 16, 2019
    This frees us from checking the FB every draw. Slightly reduces time
    spent in all draw methods. Improvement seen on the draw call overhead
    tests. Scores went from 28.17 ns/draw to 26.76 ns/draw on my machine.
    
    In a future improvement we could make this command buffer a dirty bit.
    Currently it's a bit slower to call a handler function due to the
    dispatch table. Likely we could optimize this by reverting back to a
    dirty bit switch and inlining the handler functions. That is left for
    future work.
    
    Vulkan is happy enough to run multiple RenderPasses and bind different
    Pipelines in the same command buffer. But ANGLE defers RenderPass init
    until we submit our work. Thus we can only support one RenderPass per
    secondary buffer.
    
    Test: angle_perftests DrawCall*/vulkan_null
    Bug: angleproject:3014
    Change-Id: I89fd0d9e0822400a5c5a16acb5a9c400a0e71ab5
    Reviewed-on: https://chromium-review.googlesource.com/c/1393905
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    85ca1895
UtilsVk.cpp 31.5 KB
EditWeb IDE
×

Replace UtilsVk.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.