Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • StateChangeTest.cpp
Find file
BlameHistoryPermalink
  • Qin Jiajia's avatar
    Fix the failure in UpdateImageTextureInUse · e7da32f1
    Qin Jiajia authored Dec 27, 2018
    If we update the texture data between two dispatch calls, ReadPixels can't
    get right result after the second dispatch call. The failure reason is
    that after the first dispatch, ReadPixels will sync framebufer state which
    will update color render target. Finally, TextureD3D::ensureRenderTarget
    is reached. However, we are in compute pipeline.
    mTexStorage->isRenderTarget() will be false. That results the current
    texture will create a new render target storage. But the UAV is still
    bound with the previous texture storage. If there is no texture dirty bit
    between these two dispatch calls, applyTexturesForCompute won't be called.
    After the second dispatch, readPixels will read data from the new texture
    storage which is not updated.
    
    Bug: angleproject:3015
    
    Change-Id: Ib2494ab8bf6e12faefc0a7370719d383526c36ba
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1390710Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
    e7da32f1
StateChangeTest.cpp 132 KB
EditWeb IDE
×

Replace StateChangeTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.