Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • CopyTextureTest.cpp
Find file
BlameHistoryPermalink
  • Geoff Lang's avatar
    D3D: Require cube completeness to create render targets · 5a0f64b6
    Geoff Lang authored Apr 23, 2019
    TextureD3D_Cube::isFaceLevelComplete skips checks for the base level
    because it assumes that isCubeComplete has already been called to
    verify the base level.  This assumption is not correct for some cases
    like glCopyTextureCHROMIUM which attempts to create a render target
    from cube maps that may not be complete.
    
    This caused us to create render targets from incomplete cube maps and
    then fail to upload data to the cube faces because the sizes or formats
    did not match between the images and render target.
    
    TEST=conformance/more/conformance/quickCheckAPI-S_V.html
    
    BUG=angleproject:3384
    
    Change-Id: Iceb9415debfa07436fea1eb4bc23d0ec05679839
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1578957
    Commit-Queue: Geoff Lang <geofflang@chromium.org>
    Reviewed-by: 's avatarJonah Ryan-Davis <jonahr@google.com>
    5a0f64b6
CopyTextureTest.cpp 76.9 KB
EditWeb IDE
×

Replace CopyTextureTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.