Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • common
  • debug.cpp
Find file
BlameHistoryPermalink
  • James Darpinian's avatar
    Fix ASSERT macro not printing message · 38e28257
    James Darpinian authored Mar 13, 2019
    ANGLE's ASSERT macro was often not printing the error message before
    crashing. The printing happens in the destructor of a temporary object,
    but the temporary object is not guaranteed to be destroyed before ASSERT
    calls __builtin_trap(). This change fixes it by introducing a new FATAL
    log severity that moves the __builtin_trap() call into the destructor
    after the message is printed.
    
    Bug: 780507, angleproject:2215
    Change-Id: Ica91e00d67cc95d7b59c3d59e6925ac3a93c19c5
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1521839
    Commit-Queue: James Darpinian <jdarpinian@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    38e28257
debug.cpp 6.27 KB
EditWeb IDE
×

Replace debug.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.