Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • TextureTest.cpp
Find file
BlameHistoryPermalink
  • Anders Leino's avatar
    Fix integer cube map sample HLSL calculation · e4452440
    Anders Leino authored May 09, 2019
    This patch fixes two issues in the HLSL generated to sample an integer cube map.
    The first issue was that an inappropriate major axis was selected when sampling
    from corners of the cube map. In particular, the added test case demonstrates a
    situation where a major axis of length 0 was selected, which lead to an infinite
    LOD being calculated. The fix was to adjust inequalities such that always
    exactly one of xMajor, yMajor and zMajor is true.
    The second issue was that the derivative functions ddx and ddy were being used
    on values that depended on the choice of major axis, which is not continuous at
    the corners of a cube map. This lead to a finite but incorrect LOD being
    calculated. The fix was to make sure major axis choice is not included when
    estimating the scaling factor.
    
    Bug: angleproject:3442
    Change-Id: Ia3eb8c89f47d1bfdadc18aec989e8cbebc088ec0
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1601515
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    e4452440
TextureTest.cpp 166 KB
EditWeb IDE
×

Replace TextureTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.