Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • tree_util
  • ReplaceShadowingVariables.cpp
Find file
BlameHistoryPermalink
  • Tobin Ehlis's avatar
    Vulkan:Allow same-named var in nested scope · 38ff3c70
    Tobin Ehlis authored May 15, 2019
    ESSL 1.00 spec allows for variable with same name to override outer variable
    inside of a nested scope. This change adds new scope to symbol table inside
    of a function defintion, but after function parameters for ESSL 1.00
    shaders (but not webGL). This prevents an error while parsing.
    
    This also includes some new code in translator to rename any vars that are
    redefined between the function body and the function parameters. This
    prevents an error later on when the translated shader is then parsed as
    a desktop GLSL version.
    
    Bug: angleproject:3287
    Change-Id: I3f025805cf8d65bf912283bb15e6dad6e5e9b967
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1601553
    Commit-Queue: Tobin Ehlis <tobine@google.com>
    Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    38ff3c70
ReplaceShadowingVariables.cpp 5.08 KB
EditWeb IDE
×

Replace ReplaceShadowingVariables.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.