Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • d3d
  • HLSLCompiler.cpp
Find file
BlameHistoryPermalink
  • Geoff Lang's avatar
    Disable loop unrolling when encounting errors about invalid array indices. · 96a387f8
    Geoff Lang authored Mar 15, 2019
    Zero-sized loops or loops that might never be executed may be unrolled into
    constant array accesses that are invalid, generating HLSL compiler errors.
    
    This issue showed up with the passthrough command decoder because it only does
    a single compilation step of WebGL shader -> HLSL instead of the validating
    decoder which does WebGL shader -> ESSL -> HLSL and eliminates these zero-
    sized loops in the process.
    
    BUG=angleproject:3269
    
    Change-Id: Iaa14149c542f23a6da58c90cf6de51f4df7e27d6
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1524696Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarJonah Ryan-Davis <jonahr@google.com>
    Commit-Queue: Geoff Lang <geofflang@chromium.org>
    96a387f8
HLSLCompiler.cpp 13.9 KB
EditWeb IDE
×

Replace HLSLCompiler.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.