Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • ProgramVk.cpp
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    Vulkan: Move descriptor pools into ProgramVk. · 266a9e8d
    Jamie Madill authored Jun 05, 2019
    Previously ContextVk owned the descriptor pools. We were trying to
    maximize descriptor reuse to conserve memory. However the default
    uniforms would have no possible sharing. And because uniform buffers
    are usually unique to a program it's likely there would be less reuse.
    
    Image descriptors could be shared. But with the advent of a descriptor
    cache in the Program it becomes difficult to manage the cache through
    descriptor pool recycling. Moving the pools into the Program simplifies
    the cache management. We could look at adding back more reuse in the
    future.
    
    Also shifts driver uniforms back into the end of the descriptor sets
    to make indexing into the Program's descriptor pools simpler.
    
    Bug: angleproject:3117
    Change-Id: I52bb49cf322d944ad7cf08791efdf24b7fe573ce
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1644775
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    266a9e8d
ProgramVk.cpp 42.9 KB
EditWeb IDE
×

Replace ProgramVk.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.