Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • Constants.h
Find file
BlameHistoryPermalink
  • Qin Jiajia's avatar
    Fix the crash when the array size is not big enough. · d68aff6c
    Qin Jiajia authored May 22, 2019
    Previously, we used IMPLEMENTATION_MAX_DRAW_BUFFERS(8) as the array
    size of 'previouslyBound' which is used to record whether more than two
    different blocks are bound to a single buffer. However, when the
    underlying driver is d3d11_1, the max allowed shader storage blocks will
    be 64 which is larger than 8. An assert error will be met in
    push_back like below:
    
    Test case
    'dEQP-GLES31.functional.ssbo.layout.random.all_per_block_buffers.45'..
    ERR: push_back(250):    ! Assert failed in push_back
    (../../src\common/FixedVector.h:250): mSize < N
    
    So we use 64 as the upper limit of max shader storage blocks.
    
    Bug: angleproject:3447
    Change-Id: Ie76bfd15486c1ed02afca4283d6e70bdb4298cb6
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1623794
    Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
    Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    d68aff6c
Constants.h 2.69 KB
EditWeb IDE
×

Replace Constants.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.