Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • preprocessor
  • DiagnosticsBase.cpp
Find file
BlameHistoryPermalink
  • Tobin Ehlis's avatar
    Merge ESSL pre-processsor token errors · d7013c03
    Tobin Ehlis authored Jun 17, 2019
    In both the ESSL 1.00 & 3.00 specifications having an extension directive
    after a pre-processor token is an error. Merging those two enum cases to
    be a single case. WebGL is handled as a separate warning case for any
    shader version before 3.00.
    
    Also this change now correctly marks 1.00 shaders that break this rule
    to be invalid so the ExtensionAfterNonPreProcessorTokenESSL1 test no
    longer expects handleExtension() to be called.
    
    BUG=chromium:971660
    
    Change-Id: I37b10cc0fb3a0efd6200a478171e005a96478255
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1661395Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    Commit-Queue: Tobin Ehlis <tobine@google.com>
    d7013c03
DiagnosticsBase.cpp 5.24 KB
EditWeb IDE
×

Replace DiagnosticsBase.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.