Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • SecondaryCommandBuffer.cpp
Find file
BlameHistoryPermalink
  • Shahbaz Youssefi's avatar
    Vulkan: Remove unnecessary same-layout transitions · 0fd917a2
    Shahbaz Youssefi authored Jun 23, 2019
    Previously, only read-only layouts skipped same-layout transition.  This
    is extended to color attachment and depth/stencil attachment layouts as
    well.  On Nvidia+Linux, this does reduce the number of barriers in the
    Draw* benchmarks, though there's no visible CPU-side performance
    difference.  GPU time is not measured in these tests, but it's possible
    that the driver already skips such transitions (i.e. this only saves us
    from recording an ineffective transition).
    
    Additionally, transfer dst and shader write same-layout transitions are
    turned into an execution barrier instead of a memory barrier to avoid an
    unnecessary flush.  Currently, this particularly affects texture upload,
    and shows a 10% improvement in TextureUploadSubImageBenchmark.  Note
    that this optimization is temporarily disabled due to a bug in the
    windows AMD driver.
    
    Bug: angleproject:3347
    Change-Id: I7dc9d0b5dd2ad87ec19ae13277b330438038519f
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1659149Reviewed-by: 's avatarTobin Ehlis <tobine@google.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    0fd917a2
SecondaryCommandBuffer.cpp 21.2 KB
EditWeb IDE
×

Replace SecondaryCommandBuffer.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.