Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • common
  • system_utils_unittest.cpp
Find file
BlameHistoryPermalink
  • Shahbaz Youssefi's avatar
    Reland "Add system util to execute app and retrieve its output" · a9f89313
    Shahbaz Youssefi authored Feb 25, 2019
    This reverts commit fe14b2e5.
    
    Reason for revert: failing test is reworked not to run angle_unittests
    itself, but another binary.
    
    Previously, this test was calling angle_unittests itself, but with a
    different target.  On the bots, that was in turn calling angle_unittests
    with even more arguments, including the addition of a log file location.
    Under some configurations, this separate process was thus trying to
    access files that were already opened by the parent process, leading to
    a test failure.
    
    In this CL, a new helper executable is created for the sake of this
    unittest.
    
    > Revert "Add system util to execute app and retrieve its output"
    >
    > This reverts commit c63d9552.
    >
    > Reason for revert: Test fails on Win7
    >
    > Original change's description:
    > > Add system util to execute app and retrieve its output
    > >
    > > This will be useful to run external applications, such as benchmarks,
    > > and process their output.
    > >
    > > Bug: angleproject:3125
    > > Change-Id: Ic13c69f2e034f4b47498fb2f299c62423c355c4a
    > > Reviewed-on: https://chromium-review.googlesource.com/c/1452534
    > > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    > > Reviewed-by: Jamie Madill <jmadill@google.com>
    
    Bug: angleproject:3125, angleproject:3168
    Change-Id: I74815750484a79f33c36e0b4f941d4dd98f99aa5
    Reviewed-on: https://chromium-review.googlesource.com/c/1487631
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@google.com>
    Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org>
    a9f89313
system_utils_unittest.cpp 3.88 KB
EditWeb IDE
×

Replace system_utils_unittest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.