Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • ValidateGlobalInitializer.cpp
Find file
BlameHistoryPermalink
  • Ian Elliott's avatar
    Vulkan: Enforce an error when initializing a global with a non-const · fab397e5
    Ian Elliott authored Jul 25, 2019
    The ESSL 1.0 spec is clear that "initializers must be a constant expression."
    Yet, because of "legacy" applications (apparently just WebGL applications), the
    code was only issuing a warning and not an error.  The
    "KHR-GLES2.shaders.negative.initialize" test requires an error be generated.
    This change splits the semantics, allowing GLES applications to get an error,
    and WebGL applications to get a warning.
    
    Note: This change is related to https://chromium-review.googlesource.com/829138
    (for angleproject:2285).
    
    Bug: angleproject:3381
    Change-Id: Ie243b7dd72102aeb52df506d121d1d2a8f6974d3
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1716617Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    Commit-Queue: Ian Elliott <ianelliott@google.com>
    fab397e5
ValidateGlobalInitializer.cpp 4.04 KB
EditWeb IDE
×

Replace ValidateGlobalInitializer.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.