Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • blocklayoutHLSL.cpp
Find file
BlameHistoryPermalink
  • Shahbaz Youssefi's avatar
    Fix block size calculation w.r.t variable-size arrays · 5f82dde6
    Shahbaz Youssefi authored Jan 14, 2019
    In SSBOs, there can be a last array whose size is not specified (i.e.
    can take any size).  This is especially prevalent in Compute shaders
    that process a buffer.
    
    In the shader translator, the size of this array is given as 0. HLSL
    register offset calculation was tripped up by this as it used
    (arraySize - 1). The optimization in [1] effectively removed a test
    that would perform this calculation only when the size is positive.
    This change adds back this guard.
    
    [1] https://chromium-review.googlesource.com/c/angle/angle/+/684742
    
    Bug: angleproject:2516
    Change-Id: If45ac934f542c5ffcad67f962eebe45a3aeba70b
    Reviewed-on: https://chromium-review.googlesource.com/c/1409403
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    5f82dde6
blocklayoutHLSL.cpp 5.18 KB
EditWeb IDE
×

Replace blocklayoutHLSL.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.