Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • TransformFeedbackVk.cpp
Find file
BlameHistoryPermalink
  • Ian Elliott's avatar
    Vulkan: Fix crash with glBeginTransformFeedback · 54d51f32
    Ian Elliott authored Aug 07, 2019
    The TransformFeedbackVk::onBeginEnd() method wasn't calling updateQueueSerial(),
    which was causing CommandGraphResource::hasChildlessWritingNode() to use an old
    mCurrentWritingNode, which had already been freed (i.e. Visual Studio showed it
    pointing to memory that is 0xdddddddd--which means that mCurrentWritingNode has
    been freed, but is still being used).
    
    Unfortunately, there are still other crashes affecting these tests, but they
    are the same set (and yes, there are multiple, and they are random) that cause
    most of the "KHR-GLES3.copy_tex_image_conversions.required.*" tests to crash).
    
    Bug: angleproject:3674
    Change-Id: I5cd44018ea0beb25cb218e562d5b863be6cbd450
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1742972
    Commit-Queue: Ian Elliott <ianelliott@google.com>
    Reviewed-by: 's avatarCourtney Goeltzenleuchter <courtneygo@google.com>
    54d51f32
TransformFeedbackVk.cpp 9.87 KB
EditWeb IDE
×

Replace TransformFeedbackVk.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.