Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • TextureTest.cpp
Find file
BlameHistoryPermalink
  • Cody Northrop's avatar
    Vulkan: Remove image views forced to one mip level · 6b60dfd8
    Cody Northrop authored Oct 02, 2019
    textureSize requires the view to reflect actual mip levels, so
    we can't artificially limit the view based on filtering mode.
    This CL removes those views.
    
    That unearthed a problem where the VK backend wasn't properly
    implementing non-mipmapped filter modes. There is a blurb in
    the Vulkan spec about this:
    
      There are no Vulkan filter modes that directly correspond to OpenGL
      minification filters of GL_LINEAR or GL_NEAREST, but they can be
      emulated using VK_SAMPLER_MIPMAP_MODE_NEAREST, minLod = 0, and
      maxLod = 0.25, and using minFilter = VK_FILTER_LINEAR or
      minFilter = VK_FILTER_NEAREST, respectively.
    
    So this CL also adds that emulation.
    
    Bug: angleproject:3948
    Test: TextureSizeTextureArrayTest.BaseLevelVariesInTextureArray
    Test: dEQP-GLES3.functional.shaders.texture_functions.texturesize.*
    Change-Id: I81d5c3417e7d9abd0cdd058b935963706024a28f
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1835937Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
    Commit-Queue: Cody Northrop <cnorthrop@google.com>
    6b60dfd8
TextureTest.cpp 203 KB
EditWeb IDE
×

Replace TextureTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.