Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • vk_utils.cpp
Find file
BlameHistoryPermalink
  • Tobin Ehlis's avatar
    Vulkan:Store full 64bit handle in GarbageObject · 08af1c80
    Tobin Ehlis authored Oct 22, 2019
    On 32bit builds we were only storing 32bit handles for non-
    dispatchable objects. This resulted in the handles getting shrunk
    from 64-bits which then led to false validation errors.
    
    Fixed this by using VK_DEFINE_NON_DISPATCHABLE_HANDLE() macro in
    GarbageObject instead of VK_DEFINE_HANDLE().
    
    Also MSVC on Win32 didn't like reinterpret_cast<> with the updated
    64bit handles so migrated a number of GarbageHandle casts to be
    c-style which is contrary to style guide, but is preferable to
    conditional code.
    
    Bug: angleproject:3924
    Bug: angleproject:3946
    Change-Id: Icb4139e34989179e46ac1f0c76269ff49ab1e897
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1873244
    Commit-Queue: Tobin Ehlis <tobine@google.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    08af1c80
vk_utils.cpp 33.7 KB
EditWeb IDE
×

Replace vk_utils.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.