Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • RendererVk.cpp
Find file
BlameHistoryPermalink
  • Alexis Hetu's avatar
    Vulkan: Fix memory corruption crash · 1d09b983
    Alexis Hetu authored Nov 05, 2019
    When VK_EXT_LINE_RASTERIZATION or VK_EXT_PROVOKING_VERTEX is present,
    createInfo's pNext pointer is set, which caused pEnabledFeatures to
    not be set, which ended up causing memory corruption issues.
    
    This change was made to comply with the Vulkan spec, specifically:
    "If the pNext chain includes a VkPhysicalDeviceFeatures2 structure,
     then pEnabledFeatures must be NULL"
    
    Since the VkPhysicalDeviceFeatures2 structure is only added to the
    pNext member of the createInfo structure in the if statement above,
    restoring the else statement solves this issue.
    
    Bug: angleproject:4060
    Change-Id: I0688c4297f167fa28e110cd6ee11a11b95282493
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1899731Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarTobin Ehlis <tobine@google.com>
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    1d09b983
RendererVk.cpp 68.2 KB
EditWeb IDE
×

Replace RendererVk.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.