Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • RendererVk.cpp
Find file
BlameHistoryPermalink
  • Tim Van Patten's avatar
    Vulkan: Ignore VK_INCOMPLETE from vkGetPipelineCacheData · 322220a0
    Tim Van Patten authored Nov 05, 2019
    When getting the data store from a pipeline cache, we do the following
    sequence:
    
    1.) Query the amount of data to get.
    2.) Create a buffer to hold that data.
    3.) Request that amount of pipeline cache data.
    
    This typically works without errors, but we have seen cases where the
    amount of pipeline cache data changes between steps (1) and (3). This
    leads to the driver returning VK_INCOMPLETE because we requested a
    different amount of data than the driver currently has (either too much
    or too little). However, getting at least the pipeline cache header is
    all that's required, so this isn't necessarily an error:
    
    From the Vulkan spec:
    > If pDataSize is less than the maximum size that can be retrieved by
    the pipeline cache, at most pDataSize bytes will be written to
    pData, and vkGetPipelineCacheData will return VK_INCOMPLETE. Any
    data written to pData is valid and can be provided as the
    pInitialData member of the VkPipelineCacheCreateInfo structure
    passed to vkCreatePipelineCache.
    
    This change will update ANGLE to ignore VK_INCOMPLETE, rather than
    treating it as an error.
    
    Bug: angleproject:3988
    Test: Android dEQP-GLES2.*
    Change-Id: I6518d7cb00c26ae403b58aafa86a600fa7a8504a
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1900009Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Tim Van Patten <timvp@google.com>
    322220a0
RendererVk.cpp 68.5 KB
EditWeb IDE
×

Replace RendererVk.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.