Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • ProgramVk.cpp
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    Vulkan: Fold read access into write flags on buffer writes · 61c6aecc
    Jamie Madill authored Nov 28, 2019
    This could lead to a subtle bug:
    
    Say we use a buffer as a storage buffer and write to it. We then must
    issue a memory barrier before using it as a uniform buffer. However we
    would set the SHADER_READ bit as a read mask on a storage buffer
    access. This seems like it could lead to a missing barrier.
    
    Bug: angleproject:4178
    Change-Id: I486002739b7fb000ffacc0a1e996784b7875e7ba
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1943034
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    Reviewed-by: 's avatarJonah Ryan-Davis <jonahr@google.com>
    61c6aecc
ProgramVk.cpp 68.4 KB
EditWeb IDE
×

Replace ProgramVk.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.