Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • GLSLTest.cpp
Find file
BlameHistoryPermalink
  • Shahbaz Youssefi's avatar
    Fix image/sampler uniform range in presence of atomic counters · d68bf3e2
    Shahbaz Youssefi authored Dec 04, 2019
    The change that introduced images to the front-end placed them at the
    end of the uniforms list, so the loop that was calculating the image
    range was starting from the end of that list.
    
    The change that introduced atomic counters to the front-end placed them
    at the end of the uniforms list too, but the image range loop was not
    adjusted to take this fact into account (neither was the sampler range
    loop for that matter).
    
    If a shader used both images and atomic counter buffers, the image range
    was calculated as empty.  Similar issues would arise if the shader used
    both samplers and atomic counters.
    
    A test is added where a shader has a default uniform, a UBO, an SSBO, an
    image and an atomic counter, to make sure any combination of these
    resources doesn't result in a bug.
    
    Bug: angleproject:4190
    Change-Id: I7818ee5258dd964215a18acfd7c3d6515b61c595
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950655
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarJonah Ryan-Davis <jonahr@google.com>
    d68bf3e2
GLSLTest.cpp 241 KB
EditWeb IDE
×

Replace GLSLTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.