Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • VertexArrayVk.cpp
Find file
BlameHistoryPermalink
  • Tobin Ehlis's avatar
    Vulkan:Update Vulkan Vertex Attribute Offsets · 67d8b63a
    Tobin Ehlis authored Dec 23, 2019
    This fixes most of the test for
    dEQP 3.1 KHR-GLES31.core.vertex_attrib_binding.basic-input*
    
    The bug fixes is that we were not correctly setting the vertex attribute
    offset for vertex attribs that were converted into their own buffer.
    We kept the attrib offset from the frontend as if the converted attribs
    were in the original buffer, but converted vtx attrib buffers in the VK
    backend are tightly packed from the start of the buffer so when converting
    the actual offset should be 0.
    
    Also, in order to avoid a VK validation error, this change includes a tmp
    workaround to make sure transform feedback output buffer range is never 0,
    but sets VK_WHOLE_SIZE in that case. A follow-on fix that focuses on
    transform feedback fixes will address this validation error more fully.
    
    Bug: angleproject:4145
    Bug: angleproject:4236
    Change-Id: I8c218954725945414a8f18beb4f964b90da7062a
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1980906
    Commit-Queue: Tobin Ehlis <tobine@google.com>
    Reviewed-by: 's avatarCourtney Goeltzenleuchter <courtneygo@google.com>
    Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    67d8b63a
VertexArrayVk.cpp 39.5 KB
EditWeb IDE
×

Replace VertexArrayVk.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.