Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • OutputVulkanGLSL.cpp
Find file
BlameHistoryPermalink
  • Shahbaz Youssefi's avatar
    Vulkan: Remove row->col major shader transformation · feb3b6cc
    Shahbaz Youssefi authored Jan 13, 2020
    This was done based on the incorrect assumption that Vulkan GLSL doesn't
    allow layout qualifiers on interface block fields.  This was due to
    glslang compile failures in some shaders that included mixed row- and
    column-major fields in interface blocks.
    
    However, the failures were only in the case the interface block is
    inactive, in which case glslang wrapper previously replaced the
    layout/qualifier of the interface block with |struct|, which left the
    shader with an unused struct definition with fields that have layout
    qualifiers; an invalid shader.
    
    The change introduced in
    https://chromium-review.googlesource.com/c/angle/angle/+/1951523
    removes inactive shader interface declarations.  The above scenario thus
    never occurs, rendering the row- to column-major transformation
    unnecessary.
    
    Bug: angleproject:3443
    Change-Id: Ice34a0fc6e047b79a4d44f04b730ec59bdfafe33
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961098Reviewed-by: 's avatarJonah Ryan-Davis <jonahr@google.com>
    Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com>
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    feb3b6cc
OutputVulkanGLSL.cpp 6.59 KB
EditWeb IDE
×

Replace OutputVulkanGLSL.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.