Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • ComputeShaderTest.cpp
Find file
BlameHistoryPermalink
  • Shahbaz Youssefi's avatar
    Vulkan: Fix UtilsVk dirtying driver uniforms descriptor set binding · c73475fb
    Shahbaz Youssefi authored Jan 29, 2020
    Most UtilsVk functions bind a descriptor set to index 0 (same as driver
    uniforms). If that happens to close a render pass, all is well as
    starting a new render pass ensures all descriptor sets are rebound.
    However, if the render pass is not closed, or if a dispatch call is
    issued (which never rebinds descriptor sets if not explicitly
    necessary), then the driver uniforms descriptor set may end up never
    rebound, causing a validation error (and possible crash or corruption).
    
    This change makes sure that UtilsVk notifies the context when it binds a
    descriptor set.  The context then dirties the driver uniforms binding
    as appropriate.
    
    Bug: angleproject:4272
    Change-Id: Ief20c7884fbe39712f844247489812afc70b30a9
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2027938
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    c73475fb
ComputeShaderTest.cpp 129 KB
EditWeb IDE
×

Replace ComputeShaderTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.