Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • DrawBuffersTest.cpp
Find file
BlameHistoryPermalink
  • Michael Spang's avatar
    Vulkan: Fix setupDraw when VK_EXT_transform_feedback is not enabled · abaeb415
    Michael Spang authored Jan 20, 2020
    There's no dirty bit handler if VK_EXT_transform_feedback disabled, but
    we're setting that dirty bit in syncState. This results in calling a null
    method pointer. Skip the invalidate if the extension is not enabled.
    
        gl::LogMessage::~LogMessage() at ./../../third_party/angle/src/common/debug.cpp:0
        rx::ContextVk::setupDraw(gl::Context const*, gl::PrimitiveMode, int, int, int, gl::DrawElementsType, void const*, angle::BitSetT<11ul, unsigned long, unsigned long>, rx::vk::priv::SecondaryCommandBuffer**) at ./../../third_party/angle/src/libANGLE/renderer/vulkan/ContextVk.cpp:844
        rx::ContextVk::drawArrays(gl::Context const*, gl::PrimitiveMode, int, int) at ./../../third_party/angle/src/libANGLE/renderer/vulkan/ContextVk.cpp:1698
        gl::Context::drawArrays(gl::PrimitiveMode, int, int) at ./../../third_party/angle/src/libANGLE/Context.inl.h:112
        gl::DrawArrays(unsigned int, int, int) at ./../../third_party/angle/src/libGLESv2/entry_points_gles_2_0_autogen.cpp:926
        (anonymous namespace)::AttributeLayoutNonIndexed::Draw(int, unsigned int, unsigned short const*) at ./../../third_party/angle/src/tests/gl_tests/AttributeLayoutTest.cpp:431
        (anonymous namespace)::AttributeLayoutTest::Run(bool) at ./../../third_party/angle/src/tests/gl_tests/AttributeLayoutTest.cpp:305
    
    [This stack is from the added assert; calling a null function pointer
    crashes without producing a useful stack trace.]
    
    Bug: angleproject:4326
    Change-Id: I036ae322bddc4865229fa3fe7ea72a4344b99f83
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2011408
    Commit-Queue: Michael Spang <spang@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    abaeb415
DrawBuffersTest.cpp 21 KB
EditWeb IDE
×

Replace DrawBuffersTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.