Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • TranslatorVulkan.cpp
Find file
BlameHistoryPermalink
  • Tobin Ehlis's avatar
    Revert "Vulkan:Include precision qualifier in GLSL" · a60e4973
    Tobin Ehlis authored Feb 27, 2020
    This reverts commit 93e72f5f.
    
    Reason for revert: This is having a negative impact on gfxbench
    Manhattan 3.1 tests (20-30%) with only a minor improvement (~4%) in TRex offscreen. Pulling out for now and need to re-evaluate best
    solution here.
    
    Original change's description:
    > Vulkan:Include precision qualifier in GLSL
    > 
    > With this initial implementation, it's possible to get precision
    > qualifier mis-matches in the generated GLSL 4.50. According to the
    > spec this is allowed. From GLSLangSpec 4.50 section 4.7 "Precision and
    > Precision Qualifiers":
    > 
    > For the purposes of determining if an output from one shader stage
    > matches an input of the next stage, the precision qualifier need not
    > match.
    > 
    > However, when converted to SPIR-V and run through the shader validation
    > any mismatches will cause shader validation errors. Initially just
    > ignoring those errors with this commit.
    > 
    > Bug: angleproject:3078
    > Change-Id: Ia2b04f90f0a7b6b1302c1b1b3e32bcfd8db9ed49
    > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057749
    > Reviewed-by: Jamie Madill <jmadill@chromium.org>
    > Reviewed-by: Tobin Ehlis <tobine@google.com>
    > Reviewed-by: Tim Van Patten <timvp@google.com>
    > Commit-Queue: Tobin Ehlis <tobine@google.com>
    
    TBR=tobine@google.com,timvp@google.com,jmadill@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: angleproject:3078
    Change-Id: I84984e2a963bde573f0f1de585001ceb83623c89
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2079334Reviewed-by: 's avatarTobin Ehlis <tobine@google.com>
    Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
    a60e4973
TranslatorVulkan.cpp 45.4 KB
EditWeb IDE
×

Replace TranslatorVulkan.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.