Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • RobustResourceInitTest.cpp
Find file
BlameHistoryPermalink
  • Xiaoxuan Liu's avatar
    Vulkan: Add robust init for NULL texture image. · b07816d6
    Xiaoxuan Liu authored Jan 02, 2020
    In gl::ReadPixels(), ValidateReadPixels() will try to
    flush staged updates before readPixels. In the case
    where a texture was initialized with null RGBA data,
    no Framebuffer dirty bits are set, and thus the staged
    clear would never be flushed from the staged updates.
    
    1. Add robust init in TextureVk::initImage to ensure
    image is initialized.
    
    Test: ./angle_end2end_tests --gtest_filter=\
    RobustResourceInitTest*_Vulkan_AllocateNonZeroMemory
    
    2. Update stageSubresourceRobustClear() to
    kEmulatedInitColorValue in the case where robust resource
    was initialized without full RGBA format to update
    init value of robust resource.
    
    Test: texture-attachment-formats.html in
    webgl_conformance_vulkan_passthrough_tests.
    
    3. Revert "Suppress Vulkan RobustResourceInit tests."
    Revert commit a8e6a463.
    
    Reason for revert: re-enable related robust tests.
    
    Bug: angleproject:4255
    Change-Id: I79f20e0c02c2f1b1cd68ab590f0f765229f9e780
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1985503
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    b07816d6
RobustResourceInitTest.cpp 73.8 KB
EditWeb IDE
×

Replace RobustResourceInitTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.