Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • FrameCapture.cpp
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    Capture/Replay: Write to single binary data file. · d24752e6
    Jamie Madill authored Mar 15, 2020
    Previously the tool would save to a separate file for every frame and
    one additional file for the setup function. Frames without binary data
    would not get an "angledata" binary file.
    
    Using a single file has a few advantages:
    
     - makes it simpler to track the data dependencies in GN
     - should be easier to compress and decompress for speed up transfers
     - no need to wonder if we have frames with missing data files
     - less overhead reading from the HDD since the whole trace is buffered
    
    We might need to worry about extemely huge memory use cases. For now
    buffering the whole file into memory on startup is simple and fast.
    
    Also makes the binary data loader function more robust.
    
    Bug: angleproject:4484
    Change-Id: Ia74fb0bc65200adf7a21c3143f98aa4da86457b1
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2104554
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarCourtney Goeltzenleuchter <courtneygo@google.com>
    Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com>
    d24752e6
FrameCapture.cpp 121 KB
EditWeb IDE
×

Replace FrameCapture.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.