Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • common
  • mathutil_unittest.cpp
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    Revert "Refactor BitCount" · 26f8f1a9
    Jamie Madill authored Mar 20, 2020
    This reverts commit baecb7d5.
    
    Reason for revert: Broke Skia Win/ARM builder. See issue for details.
    
    Original change's description:
    > Refactor BitCount
    > 
    > POPCNT intrinsics cannot be used without hardware support, so a CPUID
    > check and polyfills are required for some CPUs when using MSVC to
    > avoid runtime failure.
    > 
    > Other changes include:
    > - Clang: use builtins on all platforms to provide exact intent to the
    > compiler;
    > - MSVC on ARM: use dedicated intrinsics;
    > - x86/x64 fallback is now branchless and works in constant time.
    > 
    > Bug: angleproject:4462
    > Change-Id: I00fcabda1c842677d8cb4bfd280d932d0d10c0a5
    > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102811
    > Reviewed-by: Jamie Madill <jmadill@chromium.org>
    > Reviewed-by: Geoff Lang <geofflang@chromium.org>
    > Commit-Queue: Geoff Lang <geofflang@chromium.org>
    
    TBR=geofflang@chromium.org,jmadill@chromium.org,lexa.knyazev@gmail.com
    
    Change-Id: Ia1756abdf7da2aa9574149eb388915f97758bba0
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: angleproject:4462
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112276Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    26f8f1a9
mathutil_unittest.cpp 13.4 KB
EditWeb IDE
×

Replace mathutil_unittest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.