Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • Context.cpp
Find file
BlameHistoryPermalink
  • Courtney Goeltzenleuchter's avatar
    Revert "No-Op draws when no active VS and/or FS is present" · 1ab55d96
    Courtney Goeltzenleuchter authored May 06, 2020
    This reverts commit a4b506f7.
    
    Reason for revert: WebGL crash
    https://bugs.chromium.org/p/angleproject/issues/detail?id=4616
    
    Original change's description:
    > No-Op draws when no active VS and/or FS is present
    > 
    > According to the OpenGL ES 3.1 spec:
    > 
    > 7.3. PROGRAM OBJECTS
    > If there is no active program for the vertex or fragment shader
    > stages, the results of vertex and fragment shader execution will
    > respectively be undefined. However, this is not an error.
    > 
    > To handle this, if no VS or FS is present in the active Program/PPO,
    > we will no-op the draw command.
    > 
    > Bug: angleproject:3570
    > Test: KHR-GLES31.core.sepshaderobjs.StateInteraction
    > Change-Id: If19e9fbb1bc09fa0d490832079bb9f514eab6035
    > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2136386
    > Reviewed-by: Jamie Madill <jmadill@chromium.org>
    > Commit-Queue: Tim Van Patten <timvp@google.com>
    
    TBR=timvp@google.com,jmadill@chromium.org,cclao@google.com
    
    Change-Id: Ia24c4156ff7779b69c1f3f705f1a91cbb1c9684c
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: angleproject:3570
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2184849Reviewed-by: 's avatarCourtney Goeltzenleuchter <courtneygo@google.com>
    Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
    1ab55d96
Context.cpp 302 KB
EditWeb IDE
×

Replace Context.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.