Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • ProgramPipelineVk.cpp
Find file
BlameHistoryPermalink
  • Tim Van Patten's avatar
    Vulkan: PPO: Allocate uniform descriptor set if list is empty · 0e1798d6
    Tim Van Patten authored Apr 20, 2020
    When a Program is used to draw, the buffers to hold uniforms are
    allocated as part of updateUniforms(), and then if a buffer is
    allocated, a corresponding descriptor set is allocated for each shader
    stage with uniforms. However, if that Program is later bound to a PPO,
    the PPO's descriptor set list is cleared as part of creating the
    pipeline layout. This means the uniform descriptor sets need to be
    re-allocated but using the previously allocated buffers so the
    'anyNewBufferAllocated' flag isn't enough - we also need to check if
    the PPO's list of descriptor sets is empty.
    
    Bug: angleproject:3570
    Test: KHR-GLES31.core.sepshaderobjs.StateInteraction
    Change-Id: Id8df587b4f5552012590a29d120b6899bbdf677b
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2156936Reviewed-by: 's avatarCourtney Goeltzenleuchter <courtneygo@google.com>
    Reviewed-by: 's avatarCharlie Lao <cclao@google.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Tim Van Patten <timvp@google.com>
    0e1798d6
ProgramPipelineVk.cpp 6.88 KB
EditWeb IDE
×

Replace ProgramPipelineVk.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.