Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • StateChangeTest.cpp
Find file
BlameHistoryPermalink
  • Tim Van Patten's avatar
    Update State to check mExecutable · c39d25ae
    Tim Van Patten authored Jun 01, 2020
    A user may be using Program Pipelines, rather than monolithic Programs,
    so State should check if mExecutable is valid, rather than mProgram,
    since that indicates the presence of either a PPO or a Program.
    
    Exercising these paths requires additional tests:
    SimpleStateChangeTestComputeES31PPO::DeleteImageTextureInUse()
    Texture2DTestES31PPO::TexStorage()
    Texture2DTestES31PPO::SingleTextureMultipleSamplers()
    
    These new tests exposed bugs in the PPO implementation where updates to
    the active Program's ProgramExecutable were not being propagated to the
    Executables of the PPO's containing that Program. In these particular
    cases, updates to the active samplers/images/textures were not being
    copied to the PPO's Executable.
    
    Bug: angleproject:3570
    Test: end2end tests listed above
    Change-Id: I297cac2d0367f180dd7fa01a1ee7ba53996867c4
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2225417
    Commit-Queue: Tim Van Patten <timvp@google.com>
    Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    c39d25ae
StateChangeTest.cpp 180 KB
EditWeb IDE
×

Replace StateChangeTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.