Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • util
  • osx
  • OSXWindow.mm
Find file
BlameHistoryPermalink
  • Le Hoang Quyen's avatar
    Fix end2end intermittent crash on macOS if custom OSWindow is used. · 10ef43ce
    Le Hoang Quyen authored Jul 06, 2020
    In MultisammpleTest, a custom OSWindow object is created. Sometimes this
    window's internal Objective-C window object is not released after the
    test finishes, thus input events such as mouse/keyboard are still
    forwarded to this window. However its content view is already released
    causing the crash.
    
    call [mWindow setContentView:nil] inside OSXWindow::destroy() seems to
    fix this bug.
    
    Bug: angleproject:4815
    Change-Id: If00398ff0082624ade5e8be8ad3b0f91d17c23ed
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2281782
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    Reviewed-by: 's avatarJonah Ryan-Davis <jonahr@google.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    10ef43ce
OSXWindow.mm 20.8 KB
EditWeb IDE
×

Replace OSXWindow.mm

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.