Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • RenderTargetVk.cpp
Find file
BlameHistoryPermalink
  • Shahbaz Youssefi's avatar
    Vulkan: Improve RenderTargetVk's getImage interface · d9818fd6
    Shahbaz Youssefi authored Jul 19, 2020
    Prior to this change, RenderTargetVk had getImage() and
    getImageForWrite().  This change introduces getImageForCopy() and
    renames getImage() to getImageForRenderPass().
    
    Currently, all three functions do the same thing.  However, with
    upcoming changes the semantics will be different:
    
    - getImageForRenderPass(): This is the image used as the non-resolve
      attachment.  When resolve attachments are introduced, there will be a
      corresponding getResolveImageForRenderPass().
    - getImageForCopy(): When GL_EXT_multisampled_render_to_texture is
      implemented, this will return the image that owns the data.
    - getImageForWrite(): Similar to getImageForCopy(), but should set
      mContentDefined.  This is currently missing, and is a bug that will be
      resolved in a follow up.
    
    This split change gets the mechanical rename out of the way to make
    future changes simpler.
    
    Bug: angleproject:4836
    Bug: angleproject:4859
    Change-Id: I5f7657cc049c0e1772a7c510e74289e685ba93c3
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2306516
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
    d9818fd6
RenderTargetVk.cpp 6.57 KB
EditWeb IDE
×

Replace RenderTargetVk.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.