Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • ComputeShaderTest.cpp
Find file
BlameHistoryPermalink
  • Tim Van Patten's avatar
    No-Op draws when no active VS and/or FS is present · 12b6a82e
    Tim Van Patten authored Apr 03, 2020
    Re-land CL with WebGL fixes:
    This required some extra pointer checking during validation to handle
    the fact that a Program and/or ProgramExecutable may not be present when
    attempting to draw. This isn't an error, just undefined behavior, which
    we (eventually) treat as a no-op.
    
    According to the OpenGL ES 3.1 spec:
    
    7.3. PROGRAM OBJECTS
    If there is no active program for the vertex or fragment shader
    stages, the results of vertex and fragment shader execution will
    respectively be undefined. However, this is not an error.
    
    To handle this, if no VS or FS is present in the active Program/PPO,
    we will no-op the draw command.
    
    Bug: angleproject:3570
    Test: KHR-GLES31.core.sepshaderobjs.StateInteraction
    Change-Id: I70d688bf344a78cf3b4fd66c995ae03ce4b9b807
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2185156Reviewed-by: 's avatarCourtney Goeltzenleuchter <courtneygo@google.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Tim Van Patten <timvp@google.com>
    12b6a82e
ComputeShaderTest.cpp 129 KB
EditWeb IDE
×

Replace ComputeShaderTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.