Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • angletypes.cpp
Find file
BlameHistoryPermalink
  • Shahbaz Youssefi's avatar
    Vulkan: Fix deferred clears and noop clear and blit · c757e607
    Shahbaz Youssefi authored Jul 21, 2020
    Imagine the following situation:
    
    1. Clear draw framebuffer
    2. Noop operation on the framebuffer (Clear, ClearBuffer,
       BlitFramebuffer with flags specifying non-existing attachments)
    3. Change framebuffer's attachment
    4. Draw into framebuffer
    
    At step 2, FramebufferVk::syncState was called before noop-ing the
    operation.  During syncState, deferred clears were stored in the
    framebuffer and weren't flushed because the actual operation was not
    performed.
    
    At step 4, the deferred clear meant for the prior attachment gets
    applied to the new attachment.
    
    Bug: angleproject:4865
    Change-Id: I5b096bacf00356b4dccd4cbc9561b87b1bb557d8
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309224Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    c757e607
angletypes.cpp 22.2 KB
EditWeb IDE
×

Replace angletypes.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.