Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • include
  • platform
  • Feature.h
Find file
BlameHistoryPermalink
  • Yuly Novikov's avatar
    Feature::condition must not be NULL · 4609c4ac
    Yuly Novikov authored Apr 06, 2020
    Since it's returned by eglQueryStringiANGLE, and the doc says:
    1. eGLQueryStringiANGLE returns a pointer to a static, null-terminated string
    2. On failure, NULL is returned
    
    So, we shouldn't be returning NULL when there is no failure.
    This was breaking 'chrome --enable-gpu-service-logging'.
    
    Bug: angleproject:3947
    Change-Id: I2dcc7d479899dc1fc5fd59a502e84defe44f64c9
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2137939Reviewed-by: 's avatarJonah Ryan-Davis <jonahr@google.com>
    Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
    4609c4ac
Feature.h 5.31 KB
EditWeb IDE
×

Replace Feature.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.