Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • BlitFramebufferANGLETest.cpp
Find file
BlameHistoryPermalink
  • Shahbaz Youssefi's avatar
    Vulkan: Fool-proof usage of GL and VK level indices · a0d048a4
    Shahbaz Youssefi authored Aug 27, 2020
    Using boxed types, this change allows the compiler to catch errors when
    a level index in one space (e.g. GL) is mistakenly used in another space
    (e.g. VK).
    
    This change uncovered a number of bugs due to such mistakes which are
    fixed.
    
    Mistakes are still possible when the index is explicitly extracted, for
    example to be given to a Vulkan command, or when it's created, for
    example when retrieved from gl::ImageIndex::getLevelIndex.  Future work
    can include using gl::LevelIndex in gl::ImageIndex directly to alleviate
    the latter at least.
    
    Bug: angleproject:4880
    Change-Id: I6427c68c3bc096f771402f51c8554d8171758aa9
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2380232
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarCharlie Lao <cclao@google.com>
    a0d048a4
BlitFramebufferANGLETest.cpp 90.2 KB
EditWeb IDE
×

Replace BlitFramebufferANGLETest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.