Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • TransformFeedbackTest.cpp
Find file
BlameHistoryPermalink
  • Shahbaz Youssefi's avatar
    Vulkan: Fixes to transform feedback emulation path · 167a0f22
    Shahbaz Youssefi authored Aug 25, 2020
    Two bugs were affecting the following scenario:
    
    - Create program with xfb and no default uniforms
    - Draw without xfb
    - Begin xfb
    - Draw with xfb
    - End xfb
    - map and validate
    
    The first bug was that the descriptor set that contains the xfb buffers
    and default uniforms was never allocated for the first draw call
    resulting in VVL errors and crashes.
    
    The second bug was that "Begin xfb" was not setting the xfb buffers
    dirty bit, which meant that after the first draw call bound dummy
    buffers to the descriptor set, they would not get updated.  This was
    simultaneously fixed in 5d3a4ca4, but the added test nevertheless tests
    this.
    
    Bug: angleproject:4660
    Change-Id: I16eee315e39ec5a657481e54ecd0491581e886aa
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2376172Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    167a0f22
TransformFeedbackTest.cpp 75.5 KB
EditWeb IDE
×

Replace TransformFeedbackTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.