Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • VulkanUniformUpdatesTest.cpp
Find file
BlameHistoryPermalink
  • Tim Van Patten's avatar
    Vulkan: Match descriptor pool sizes to descriptor set layouts · f12e4123
    Tim Van Patten authored Aug 25, 2020
    When a descriptor pool is created, a list of descriptor types and counts
    are given to vkCreateDescriptorPool(). Later, when allocating a
    descriptor set from the pool, we pass along a descriptor set layout to
    vkAllocateDescriptorSets() which is used to determine how many of each
    type of descriptor (i.e. binding) to allocate from the pool.
    
    In order for our "free descriptor set" counts to be accurate for each
    pool, the descriptor pools need to be created with descriptor counts
    that match the descriptor set layout binding counts.
    
    This change fixes a bug where the descriptor set layouts were created
    with more bindings than the descriptor pool sizes, causing the "free
    descriptor set" count to be inaccurate, leading to allocating too many
    descriptor sets from a pool.
    
    Bug: angleproject:3570
    Test: VulkanDescriptorSetTest
    Change-Id: I660bf02d29a1291391fb15f39e6479bf348d0f83
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2391114
    Commit-Queue: Tim Van Patten <timvp@google.com>
    Reviewed-by: 's avatarCharlie Lao <cclao@google.com>
    Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    f12e4123
VulkanUniformUpdatesTest.cpp 23.6 KB
EditWeb IDE
×

Replace VulkanUniformUpdatesTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.