Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • vk_helpers.cpp
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    Revert "Vulkan: Implement a SharedResourceUse pool" · 68a5baeb
    Jamie Madill authored Sep 23, 2020
    This reverts commit de335c16.
    
    Reason for revert: Might actually regress CPU overhead perf.
    Unsure but it's possible the reported perf improvement was due
    to variance.
    
    Original change's description:
    > Vulkan: Implement a SharedResourceUse pool
    > 
    > When adding a Resource to the ResourceUseList of ContextVk
    > we constructed a new SharedResourceUse object for tracking
    > and update of the Resource's Serial. We would then delete
    > it after releasing the resource. This incurs repeated
    > memory operation costs.
    > 
    > Instead we now allocate a pool of SharedResourceUse objects
    > and acquire and release from this pool as needed.
    > 
    > VTune profile of the Manhattan 30 offscreen benchmark
    > shows the CPU occupancy of bufferRead decrease from an
    > average of 0.9% -> 0.6% and imageRead decreases from
    > an average of 0.4% -> 0.3%. The bottleneck for both
    > these methods is the retain() method that leverages
    > the new SharedResourceUse pool.
    > 
    > Bug: angleproject:4950
    > Change-Id: Ib4f67c6f101d4b2de118014546e6cc14ad108703
    > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2396597
    > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
    > Reviewed-by: Jamie Madill <jmadill@chromium.org>
    > Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
    
    TBR=syoussefi@chromium.org,jmadill@chromium.org,m.maiya@samsung.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: angleproject:4950
    Change-Id: I40081551c3db67d6e55182fea40119946ed16ac3
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2426479Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    68a5baeb
vk_helpers.cpp 230 KB
EditWeb IDE
×

Replace vk_helpers.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.