Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • common
  • debug.cpp
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    Revert "Vulkan:Add debug labels for OpenGL calls" · 6534a6f8
    Jamie Madill authored Oct 02, 2020
    This reverts commit 3705fc41.
    
    Reason for revert: Causes errors on Debug bots. See bug.
    
    Bug: angleproject:5121
    
    Original change's description:
    > Vulkan:Add debug labels for OpenGL calls
    >
    > Implement the DebugAnnotatorVk class, and plumb the EVENT macro in the
    > GL entrypoints to save a string of call info in the vector of all
    > GL calls in ContextVk.
    >
    > Then add a vkCmdBeginDebugUtilsLabelEXT() call that includes the
    > OpenGL draw/dispatch call prior to any Vulkan Draw or Dispatch calls.
    > Also embedded under that label add a second
    > vkCmdBeginDebugUtilsLabelEXT() call labeled "OpenGL Commands" that
    > includes all of the OpenGL calls leading up to the draw/dispatch.
    > Each individual OpenGL call is then given its own
    > vkCmdBegin/EndDebugUtilsLabelEXT() pair so that the complete sequence
    > of GL calls leading up to a draw call is visible for each Draw.
    >
    > Enable the OGL->VK mapping feature by setting
    > "angle_enable_trace = true" in GN args.
    >
    > Note: This will create an ANGLE APK on Android that generally won't
    > work with games, unless launched by AGI (which provides the debug
    > utils extension).  A future version will disable these labels unless
    > the debug utils extension is found.
    >
    > Bug: b/162068318
    > Bug: b/169243237
    > Change-Id: I09886f17fa9287528c12552698738ea1fe2a4b8c
    > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2427557
    > Commit-Queue: Ian Elliott <ianelliott@google.com>
    > Reviewed-by: Tim Van Patten <timvp@google.com>
    > Reviewed-by: Jamie Madill <jmadill@chromium.org>
    > Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
    > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
    
    TBR=courtneygo@google.com,ianelliott@google.com,timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: b/162068318
    Bug: b/169243237
    Change-Id: I772d549213e1ad64ae58a1937e5de0f7ea740084
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444094Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org>
    Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
    6534a6f8
debug.cpp 8.08 KB
EditWeb IDE
×

Replace debug.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.