Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • RenderTargetVk.cpp
Find file
BlameHistoryPermalink
  • Charlie Lao's avatar
    Vulkan: Defer the depthStencil buffer layout change to endRenderPass · 77e3d0ae
    Charlie Lao authored Sep 25, 2020
    Depth stencil layout may change while we build the render pass,
    depending on the read/write access been made. Right now we are always
    inserting a layout change barrier at the start of render pass.  Later on
    when the read/write property changes, we insert another layout change
    barrier. Similarly, we maintain the attachmentOps and
    RenderPassDesc::mPackedColorAttachmentRangeAndDSAccess as we changes
    read/write access. This makes code quite commplicated. This CL moves
    mReadOnlyDepthStencilMode from FramebufferVK to CommandBufferHelper
    object and we only maintain that boolean while we updating the
    read/write access. Then at the end of render pass or when depthStencil
    image is deleted, we update attachmentOps and mRenderPassDesc and layout
    transition all at once and only done once. This simplifies the read only
    depth stencil mode implementation a lot.
    
    Bug: b/168953278
    Change-Id: Ie263b4526c82a9858e5d1f141ea58f499187a3ca
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2432075
    Commit-Queue: Charlie Lao <cclao@google.com>
    Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    77e3d0ae
RenderTargetVk.cpp 10.6 KB
EditWeb IDE
×

Replace RenderTargetVk.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.