-
Revert 4 Vulkan content defined CLs. · d6b1c17bJamie Madill authored
Revert "Vulkan: Avoid content restore by detecting no-op stencil" This reverts commit 243d0f89. Revert "Vulkan: Restore at the end of RP if write-after-invalidate" This reverts commit e5d52ac3. Revert "Vulkan: Invalidate/restore depth/stencil separately." This reverts commit 61fa0878. Revert "Vulkan: Move content-defined tracking to ImageHelper" This reverts commit 2392e6b3. Causes crashes in Fuchsia x64 and on ARM. Original CL message: Content-defined tracking was done in render targets prior to this change. This had multiple drawbacks: - When a framebuffer attachment is changed (including the first time it's set), it's unknown whether the contents of the attachment is defined. - Invalidate takes effect at the end of render pass, at which point the render target objects may be gone. Attachment ImageHelpers are however correctly tracked. This change moves content-defined tracking to the ImageHelper itself, and tracks it per subresource. ImageHelper::onWrite() now receives the subresource that is being written, and marks it as having defined content. A future optimization can make use of this change to ImageHelper::onWrite to track "dirty" subresources. This can lead to the removal of unnecessary barriers when same-kind writes are done on different subresources of the image. See http://anglebug.com/3347#c15 Bug: b/167275320 Bug: angleproject:4836 Bug: angleproject:5159 Change-Id: I93d9dfe973caa7ce70aefa46b5b7d04a8637efb3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2464822Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
d6b1c17b
×