Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • angletypes.cpp
Find file
BlameHistoryPermalink
  • Shahbaz Youssefi's avatar
    Reland: "4 Vulkan content defined CLs." · 68bd685a
    Shahbaz Youssefi authored Oct 10, 2020
    Reland "Vulkan: Avoid content restore by detecting no-op stencil"
    This relands commit 243d0f89.
    
    Reland "Vulkan: Restore at the end of RP if write-after-invalidate"
    This relands commit e5d52ac3.
    
    Reland "Vulkan: Invalidate/restore depth/stencil separately."
    This relands commit 61fa0878.
    
    Reland "Vulkan: Move content-defined tracking to ImageHelper"
    This relands commit 2392e6b3.
    
    Reason for revert: Caused crashes in Fuchsia x64 and on ARM.
    Reland fixes content defined for external images.
    
    Original CL message:
    
    Content-defined tracking was done in render targets prior to this
    change.  This had multiple drawbacks:
    
    - When a framebuffer attachment is changed (including the first time
      it's set), it's unknown whether the contents of the attachment is
      defined.
    - Invalidate takes effect at the end of render pass, at which point the
      render target objects may be gone.  Attachment ImageHelpers are
      however correctly tracked.
    
    This change moves content-defined tracking to the ImageHelper itself,
    and tracks it per subresource.  ImageHelper::onWrite() now receives the
    subresource that is being written, and marks it as having defined
    content.
    
    A future optimization can make use of this change to
    ImageHelper::onWrite to track "dirty" subresources.  This can lead to
    the removal of unnecessary barriers when same-kind writes are done on
    different subresources of the image.  See http://anglebug.com/3347#c15
    
    Bug: b/167275320
    Bug: angleproject:4836
    Bug: angleproject:5159
    Change-Id: If5c1ae7152657fd7c94db7d55bea4fb9ddf835ba
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2464825Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    68bd685a
angletypes.cpp 23.9 KB
EditWeb IDE
×

Replace angletypes.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.