Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • test_expectations
  • GPUTestConfig.cpp
Find file
BlameHistoryPermalink
  • David Benjamin's avatar
    Fix out-of-bounds access bug in ANGLE tests · f60da874
    David Benjamin authored Nov 19, 2019
    When not filled in, as in Android, activeGPUIndex is -1. This is fine
    for Android because it doesn't use vendorID, but the function computed
    vendorID unconditionally without checking for -1.
    
    Default activeGPUIndex to 0 instead of -1. Note code still needs to
    check for systemInfo.gpus.empty().
    
    This caused crashes when _LIBCPP_DEBUG=0 was enabled.
    
    Bug: chromium:923166
    Change-Id: If4d1dff9553a580fd92bc0497fc092789d07ed93
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1925031Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
    f60da874
GPUTestConfig.cpp 14.5 KB
EditWeb IDE
×

Replace GPUTestConfig.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.