Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • GLSLTest.cpp
Find file
BlameHistoryPermalink
  • Mohan Maiya's avatar
    Check for precision match of uniforms only if there is static use · f037cdc4
    Mohan Maiya authored Oct 23, 2020
    There are legacy apps that have uniforms declared with
    different precisions across shaders. There is some wiggle
    room in the ESSL spec to accommodate such cases as long as
    the uniforms are not statically used in shaders. We choose
    this lenient interpretation since it allows for more apps
    to be compatible with ANGLE.
    
    This change allows BADLANDS to progress past a black screen.
    
    Bug: angleproject:4971
    Tests: angle_end2end_tests
               --gtest_filter=GLSLTest_ES31.UniformPrecisionMatchValidation*
    Change-Id: Icdd2056c8415803eb34f2840b0758e1acf53c23a
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495493
    Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    f037cdc4
GLSLTest.cpp 275 KB
EditWeb IDE
×

Replace GLSLTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.